[question/proposal] use of enums for event names?

[oscard0m]

[❓question] Would have sense to use enums for event names?

webhooks.js/index.d.ts

Lines 4402 to 4417 in 5ca6c8a

	event:
	| "pull_request"
	| "pull_request.assigned"
	| "pull_request.closed"
	| "pull_request.edited"
	| "pull_request.labeled"
	| "pull_request.locked"
	| "pull_request.opened"
	| "pull_request.ready_for_review"
	| "pull_request.reopened"
	| "pull_request.review_request_removed"
	| "pull_request.review_requested"
	| "pull_request.unassigned"
	| "pull_request.unlabeled"
	| "pull_request.unlocked"
	| "pull_request.synchronize",

A use case where it would be valuable is to make sure the events to be listened webhooks.on([<eventName>]) are the right ones on compile time.

If you think is a valid proposal I would be more than happy to propose a pull-request for it! :)

[gr2m]

Yes, I think that'd be great!

[oscard0m]

I drafted a Pull Request to agree on the approach to follow to generate the enums, could someone take a look? Should I draft the PR over octokit?

Let me know which should be the approach

[github-actions]

🎉 This issue has been resolved in version 7.8.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀