Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools-update didn't work properly #50

Closed
kamilsk opened this issue Mar 5, 2021 · 3 comments
Closed

tools-update didn't work properly #50

kamilsk opened this issue Mar 5, 2021 · 3 comments
Assignees

Comments

@kamilsk
Copy link
Member

kamilsk commented Mar 5, 2021

at go-service:

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
+       github.com/golangci/golangci-lint v1.38.0

but expected

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
-       github.com/grpc-ecosystem/grpc-gateway/v2 v2.2.0
+       github.com/golangci/golangci-lint v1.38.0
+       github.com/grpc-ecosystem/grpc-gateway/v2 v2.3.0
-       google.golang.org/protobuf v1.25.0
+       google.golang.org/protobuf v1.25.1-0.20201208041424-160c7477e0e8

so, why it's happening as above?

@kamilsk kamilsk self-assigned this Mar 5, 2021
@kamilsk
Copy link
Member Author

kamilsk commented Mar 5, 2021

maybe it's happening because I also depend on google.golang.org/protobuf v1.25.0
in this case it try to find that version of github.com/grpc-ecosystem/grpc-gateway/v2 which compatible with the version of protobuf.

@kamilsk
Copy link
Member Author

kamilsk commented Mar 5, 2021

Also I have a lot of indirect deps (go-service) and one for go-tool:

require (
	github.com/golang/mock v1.5.0
	github.com/golangci/golangci-lint v1.38.0
	github.com/kyoh86/looppointer v0.1.7
	golang.org/x/exp v0.0.0-20210220032938-85be41e4509f
	golang.org/x/text v0.3.4 // indirect
	golang.org/x/tools v0.1.0
)

@kamilsk
Copy link
Member Author

kamilsk commented Apr 10, 2021

it depends on kamilsk/egg#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant