Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckUserPassword RPC to user.proto #21

Open
Feyzanrs opened this issue May 17, 2024 · 0 comments · May be fixed by #29
Open

Add CheckUserPassword RPC to user.proto #21

Feyzanrs opened this issue May 17, 2024 · 0 comments · May be fixed by #29
Assignees
Labels
Be enhancement New feature or request feature Proposal or implementation of new features

Comments

@Feyzanrs
Copy link
Member

A new RPC, CheckUserPassword, needs to be added to pkg/proto/model/user.proto. This RPC checks user information and password. Additionally, a new message type, UserWithPassword, needs to be added.

service UserSvc {
    rpc GetUsersByFilter(UserFilter) returns (Users) {}
    rpc CreateUser(User) returns(User)  {}
    rpc DeleteUser(User) returns (User) {}
    rpc UpdateUserRole(User) returns (User) {}
    rpc UpdateUserBase(User) returns (User) {}
    rpc UpdateUserStatus(User) returns (User) {}
    rpc ChangePassword(UserPassword) returns (UserPasswordResult) {}
    rpc CheckUserPassword(UserWithPassword) returns (User) {} // new
}
// this message is new and it will be added like the other messages 
message UserWithPassword {
    User user = 1;
    UserPassword userPassword = 2;
}

Please Note: The comment lines are included here for better understanding and do not need to be added to the actual implementation.

@Feyzanrs Feyzanrs added enhancement New feature or request feature Proposal or implementation of new features labels May 18, 2024
@Smnrgcl Smnrgcl linked a pull request Jun 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Be enhancement New feature or request feature Proposal or implementation of new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants