Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for whitenoise serving to avoid regression #27

Open
thclark opened this issue Jan 22, 2024 · 0 comments
Open

Add test for whitenoise serving to avoid regression #27

thclark opened this issue Jan 22, 2024 · 0 comments

Comments

@thclark
Copy link
Contributor

thclark commented Jan 22, 2024

Feature request

The fix in #25 requires an edit to the source map line at the end of the bundled javascript for svelte-jsoneditor.

When upgrading in future, this is an area where it'd be very easy to create a regression, because it'd be my tendency to forget this happened and dump the new JS straight into that file.

We want reliable releases without regressing this bug.

Proposed Solution

Suggest that whitenoise is included in our development dependencies and a test case is introduced that overrides settings to use whitenoise to serve the JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant