Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log analysis to socket #35

Closed
thclark opened this issue Nov 26, 2020 · 7 comments · Fixed by #36
Closed

Log analysis to socket #35

thclark opened this issue Nov 26, 2020 · 7 comments · Fixed by #36
Assignees
Labels
backend Related to the back end feature A new feature of the app

Comments

@thclark
Copy link
Contributor

thclark commented Nov 26, 2020

When setting up the analysis logging, optionally create an additional handler to send log entries to a websocket, whose a URI could be passed as a CLI option then into the runner.

This will enable the logs from the analyses to be streamed back to the end user.

@cortadocodes how do you feel about taking this one on?

Testing

I'm not sure how to create a websocket for testing purposes but it must be doable.

@thclark thclark added feature A new feature of the app backend Related to the back end labels Nov 26, 2020
@thclark thclark added this to Triage in Twined Ecosystem Roadmap via automation Nov 26, 2020
@thclark thclark moved this from Triage to Twined v0.0.x in Twined Ecosystem Roadmap Nov 26, 2020
@cortadocodes
Copy link
Member

Sounds good!

@cortadocodes cortadocodes self-assigned this Nov 26, 2020
@thclark
Copy link
Contributor Author

thclark commented Nov 27, 2020

I'm working over in django-twined on the task broker and am calling the parameter logger_uri

@cortadocodes
Copy link
Member

I'm not sure how to create a websocket for testing purposes but it must be doable.

@thclark would this be to test the ability to stream log output to a URI?

@thclark
Copy link
Contributor Author

thclark commented Nov 27, 2020

I'm not sure how to create a websocket for testing purposes but it must be doable.

@thclark would this be to test the ability to stream log output to a URI?

Yes. (or whatever mocking/patching would be done instead to test the core funcionality)

@cortadocodes
Copy link
Member

Did you want this to accept ws and wss protocols as well as http and https?

@thclark
Copy link
Contributor Author

thclark commented Dec 7, 2020

I've perhaps skimmed too quickly. How can you log to a websocket over https? Surely this should only be ws and wss?

@cortadocodes
Copy link
Member

I think websockets are compatible with https although the main reason is that I assumed websocket meant an http port. I'll look into and amend this now.

Twined Ecosystem Roadmap automation moved this from Twined v0.0.x to Done Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the back end feature A new feature of the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants