Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: auto-select only benchmarks #423

Open
ElectreAAS opened this issue Mar 13, 2023 · 0 comments
Open

Frontend: auto-select only benchmarks #423

ElectreAAS opened this issue Mar 13, 2023 · 0 comments

Comments

@ElectreAAS
Copy link
Contributor

For example, at the moment for ppxlib:
Clicking on ppxlib in the sidebar leads to https://autumn.ocamllabs.io/ocaml-ppx/ppxlib which immediately redirects to https://autumn.ocamllabs.io/ocaml-ppx/ppxlib?worker=autumn&image=ocaml%2Fopam%3Adebian-ocaml-5.0 (so we add the worker and the image), but it still says "No data for selected interval".
We could instead link/redirect to https://autumn.ocamllabs.io/ocaml-ppx/ppxlib/benchmark/benchmarks?worker=autumn&image=ocaml%2Fopam%3Adebian-ocaml-5.0 (which links to the "benchmarks" benchmarks (it's their name), on top of the other parameters), which actually produces the graphs.

When there is only one such benchmark we could do that automatically, and when there are multiple, we probably should have something more informative than "No data for selected interval" and instead point to the benchmarks on the left.

@ElectreAAS ElectreAAS changed the title Frontend: auto-select only valid benchmarks Frontend: auto-select only benchmarks Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant