Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current_git: support private repositories #406

Open
patricoferris opened this issue Feb 6, 2023 · 1 comment
Open

current_git: support private repositories #406

patricoferris opened this issue Feb 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@patricoferris
Copy link
Contributor

This issue has been brought up a few times (ocurrent/ocluster#179, ocurrent/ocaml-ci#323) but I thought I would open it on the repository where the fix/feature would have to start!

Currently, current_git does not support checking out private repositories. For now, I'll limit the discussion to Github repos. There's a few ways off of the top of my head you could go about trying to fix this:

  1. Passing in a Github token to be placed in the URL when doing the fetch. Something like this code with some overriding of the pp_cmd to not leak the token in the logs. This works until your submodules are also private.
  2. Setup either the main account on the machine you are running to have access to Github or setup some user on the machine with access and run git as them. This doesn't feel great and probably will have permission errors.
  3. There might be some sort of thing we can with git-credentials and a token to overcome the submodule problem, I'm not sure.

Any other ideas?

@patricoferris patricoferris added the enhancement New feature or request label Feb 6, 2023
@tmcgilchrist
Copy link
Member

POC by @maiste #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants