Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parameters not passed for some entries #21

Closed
ferrigno opened this issue Feb 2, 2024 · 5 comments
Closed

Default parameters not passed for some entries #21

ferrigno opened this issue Feb 2, 2024 · 5 comments
Assignees
Labels
feature Something we know we do not have and want to add

Comments

@ferrigno
Copy link

ferrigno commented Feb 2, 2024

T1='2022-10-22T05:18:22' # http://odahub.io/ontology#StartTime
T2='2022-10-22T23:10:16' # http://odahub.io/ontology#EndTime
src_name="Her X-1" # http://odahub.io/ontology#AstrophysicalObject
RA=0. # http://odahub.io/ontology#PointOfInterestRA
DEC=0. # http://odahub.io/ontology#PointOfInterestDEC

These parameters are not shown with the default values that is in the notebook. Is it expected ?

https://gitlab.renkulab.io/astronomy/mmoda/ibis-isgri-spectrum

@ferrigno ferrigno added the feature Something we know we do not have and want to add label Feb 2, 2024
@dsavchenko
Copy link
Member

"Source query" parameters are different from others and have some restrictions.

  1. Defaults are the same for the entire instrument, regardless of the product name. So if there are several notebooks in a repo, defaults are taken from one of them only.
    1.5. Moreover, if e.g. time bounds are used in every notebook, but not coordinates, defaults for coordinates and times may come from different notebooks. (This is the only point which may be addressed comparably easy).
  2. Default values are not shown in the frontend. This is done intentionally, we don't want tab switching to affect upper panel (to easily get results for the same source with different instruments)
  3. But you can see default values in dispatcher response (through oda_api, for example)

@ferrigno
Copy link
Author

ferrigno commented Feb 6, 2024

Thanks for the explanations.

  • In this case, it is better to split between IBIS/ISGRI and JEM-X.
  • Do you know why boolean parameters do not take a default value? (they are not present in all notebooks)
    image
  • Is there a way to order the appearance of parameters?
  • The variable name with underscores is ugly, is there a way to specify a dctionary as {'var_name': 'Pretty Variable Name'} ?

@dsavchenko
Copy link
Member

dsavchenko commented Feb 6, 2024

  • The variable name with underscores is ugly, is there a way to specify a dctionary as {'var_name': 'Pretty Variable Name'} ?

There is an issue to add annotations for parameter labels oda-hub/dispatcher-plugin-nb2workflow#53 but it's not implemented for MMODA, it requires a change in dispatcher. (But the annotation term is used for galaxy tool generation, so you can use it already for the future http://odahub.io/ontology#label)

Is there a way to order the appearance of parameters?

There is no way to do it. I'm not even sure how does the order form. Need to explore.

Do you know why boolean parameters do not take a default value? (they are not present in all notebooks)

I don't know for a moment. Created an issue #24, will explore

@ferrigno
Copy link
Author

ferrigno commented Feb 6, 2024

Thanks. Could you point to an example of this label annotation ?

@dsavchenko
Copy link
Member

dsavchenko commented Feb 7, 2024

See pixsize parameter annotation here
Note the whitespace before ;, it's required!

@ferrigno ferrigno closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we know we do not have and want to add
Projects
None yet
Development

No branches or pull requests

2 participants