Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-capstone-project (Kanban board) #21

Open
2 tasks
odaialazzeh opened this issue Nov 28, 2022 · 2 comments
Open
2 tasks

JS-capstone-project (Kanban board) #21

odaialazzeh opened this issue Nov 28, 2022 · 2 comments

Comments

@odaialazzeh
Copy link
Owner

@ichala
Copy link

ichala commented Nov 28, 2022

Hi @odaialazzeh
Good job so far!
👏👏👏
There are some issues that you still need to work on to go to the next project but you're almost there!

the-simpsons-homer-simpson

To Highlight 🎉

  • Kanban board Created ✔️
  • Group Task Assigned 👏 ✔️

Required Changes ♻️

  • 🛑 As part of the requirements, you should decide who is Student A & who is Student B. So each card with Student A in its title should always be assigned to the same student (and analogical for other students). so kindly assign your selves to the correct unassigned cards 🙏

image

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@leonardodiasb
Copy link

Status: ✔️ Project Approved ✔️

Hello @odaialazzeh 🔥

You worked hard in all the instructions that the previous Code Reviewers give you👍🏽

Now you can close this issue. 🚀

Highlights

Kanban board Created ✔️
Group Task Assigned 👏 ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants