Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detect iconv on MacOS #13

Merged
merged 1 commit into from Jan 30, 2019
Merged

feat: detect iconv on MacOS #13

merged 1 commit into from Jan 30, 2019

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Jan 29, 2019

detect libiconv on MacOS

@salzig
Copy link
Contributor Author

salzig commented Jan 30, 2019

Testsuite is falling caused by a missing api token.

Looks like php/bin/list-all relies on GitHub releases
but it does not properly sets an Authorization header to prevent
GitHub API rate limiting.

@odarriba
Copy link
Contributor

Thanks for your time contributing to this package! ❤️

@odarriba odarriba merged commit a732ca8 into asdf-community:master Jan 30, 2019
@salzig salzig deleted the feat/detect_iconv branch January 30, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salzig @odarriba