Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unit test code that generates OData links #23

Closed
LianwMS opened this issue Jan 12, 2015 · 2 comments
Closed

Can't unit test code that generates OData links #23

LianwMS opened this issue Jan 12, 2015 · 2 comments
Labels
Milestone

Comments

@LianwMS
Copy link
Contributor

LianwMS commented Jan 12, 2015

There's no unit that encapsulates the logic around generating a full OData
link, so tests end up integration style. Having an odata link factory
abstraction allows unit testing such code.

We are putting two related properties together on the request: path handler
and route name. These are a pair, which is a code smell that there's one
abstraction here that should be used instead. Having an odata link factor also
solves this problem.

Work Item Details

Original CodePlex Issue: Issue 769
Status: Active
Reason Closed: Unassigned
Assigned to: Unassigned
Reported on: Jan 12, 2013 at 1:50 AM
Reported by: davidmatson
Updated on: Sep 23, 2013 at 7:45 PM
Updated by: danroth27

@LianwMS
Copy link
Contributor Author

LianwMS commented Jan 12, 2015

On 2013-03-13 05:15:42 UTC, HongmeiG commented:

Can you improve this as part of your unit testability work?

@xuzhg
Copy link
Member

xuzhg commented May 31, 2016

Close it. Please file a new issue if you have further concern. Thanks.

@xuzhg xuzhg closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants