Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing reflect metadata #11

Closed
irissoftworks opened this issue Mar 24, 2019 · 1 comment
Closed

Importing reflect metadata #11

irissoftworks opened this issue Mar 24, 2019 · 1 comment

Comments

@irissoftworks
Copy link

irissoftworks commented Mar 24, 2019

Thanks for the amazing work with this package.

One quick question, I realized at the index:
import 'reflect-metadata'

This may cause issues if it is included twice, and the official typeorm doc recommends importing it.

I was wondering if importing reflect-metadata should be kept as consumer responsibility, or alternatively could the doc be updated to point out the fact that it is included already ?

@odavid
Copy link
Owner

odavid commented Mar 24, 2019

@irissoftworks - Sorry for that.
Removed it.

@odavid odavid closed this as completed Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants