Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I load this in a custom-element, so it can access shadow-dom? #170

Open
herrKlein opened this issue Apr 22, 2024 · 1 comment
Open

Comments

@herrKlein
Copy link

Hi, really nice polyfill.

I would like the example which keeps the container in the viewport. I have 2 questions.
Does it work with shadowdom. I would like to use it for a custom dropdown component where the popup has to stay inside the window.

Second question is, I see the example constantly updating when it overlaps the border of the scrollable content. Wouldn't that make it slow. Is that a bug?

Screenshot 2024-04-22 at 11 30 53

@jgerigmeyer
Copy link
Member

Does it work with shadowdom. I would like to use it for a custom dropdown component where the popup has to stay inside the window.

That's a great question, and my answer is honestly "I'm not sure." We paused development on this polyfill to allow the spec to stabilize (see comment here), and I don't think we've tested with custom components yet. If you have time to test that out, please report back!

Second question is, I see the example constantly updating when it overlaps the border of the scrollable content. Wouldn't that make it slow. Is that a bug?

Yes, that certainly looks like a bug to me. Would you be willing to open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants