Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTML minifier? #186

Closed
jgerigmeyer opened this issue Nov 8, 2017 · 2 comments
Closed

Remove HTML minifier? #186

jgerigmeyer opened this issue Nov 8, 2017 · 2 comments
Assignees
@jgerigmeyer
Labels
code cleanup ready for review
Milestone
Backlog

Comments

@jgerigmeyer
Copy link
Member

How much do we really gain from minifying the compiled HTML files? Is that level of performance increase important for a styleguide?

Only reason to remove it would be to make diffs much more readable.
@jgerigmeyer jgerigmeyer added this to the Herman 1.x Stretch Goals milestone Nov 8, 2017
@jgerigmeyer
Copy link
Member Author

@mirisuzanne @wlonk @davisagli What do y'all think about this? I'd find it helpful for development, and probably also for users who check in their docs (e.g. OddSite).

@mirisuzanne
Copy link
Member

I agree. People could add a minification step in their own build process if they really need it, right?

@jgerigmeyer jgerigmeyer mentioned this issue Nov 8, 2017
Merged
@jgerigmeyer jgerigmeyer self-assigned this Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgerigmeyer jgerigmeyer

Labels
code cleanup ready for review
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@mirisuzanne @jgerigmeyer