Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with include-media library #524

Open
nirazul opened this issue Sep 8, 2015 · 5 comments
Open

Compatibility with include-media library #524

nirazul opened this issue Sep 8, 2015 · 5 comments

Comments

@nirazul
Copy link

nirazul commented Sep 8, 2015

Hey there!

I've seen your talk at frontendconf zurich and waited since then for a new project to use susy.
I just played around for some hours but I'm positive that this is a great replacement for the bootstrap grid I've used for far too long. So first of all, a big thanks for providing such a great plugin (and a great talk aswell)!

As I'm also fond of using include-media, would it be possible to use its media mixin instead of breakpoint?

@mirisuzanne
Copy link
Member

I don't think we'll bake this into the existing Susy 2 syntax, but it's a great idea for a v3 plugin. In the meantime, building your own integration is relatively straight forward. You just need a wrapper mixin that takes both media and Susy with-layout arguments. Then pass those arguments on to both:

@mixin my-media-mixin($layout, $conditions...) {
  @include with-layout($layout) {
    @include media($conditions...) {
      @content;
    }
  }
}

You can mess with that syntax if you want - but that's about all it takes.

@mirisuzanne
Copy link
Member

Also, welcome to Susy! Glad you enjoyed the talk!

@nirazul
Copy link
Author

nirazul commented Sep 8, 2015

That looks easy enough for the moment. Thanks for the quick help! :)

@nirazul nirazul closed this as completed Sep 8, 2015
@mirisuzanne
Copy link
Member

I'm going to keep this open as a reminder about v3 plugin ideas

@mirisuzanne mirisuzanne reopened this Sep 8, 2015
@KittyGiraudel
Copy link
Contributor

Hey. Allow me to dive in as I happen to be one of the two authors of include-media. We might also consider having an include-media plugin (because we do rely on a plugin system as well) for Susy, depending on what you have in mind.

In any case and in regard to Susy, this is definitely something meant to be a plugin and won't be part of the core. :)

@KittyGiraudel KittyGiraudel changed the title add breakpoint support for include-media Compatibility with include-media library Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants