New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better diff-ing library #15

Closed

odeke-em opened this issue Dec 31, 2014 · 1 comment

Labels

bug

Owner

odeke-em commented Dec 31, 2014

The current diff-ing library trips out at about > 5MB or so with a panic due to a slice out of bounds error.

odeke-em added the bug label

Owner Author

odeke-em commented Jan 1, 2015

Addressed by: f9bf49e
Using the host system's diff util because doing it in go would require:

Downloading the remote file (n bytes)
Loading the local file into memory (m bytes)
Loading the remote file into memory (p bytes)
Diffing the content in memory (m + p + K bytes)

This is straineous on the system.

I'd rather:

Download the remote file (n bytes)
Issue a syscall to perform the diff.

odeke-em closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment