Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.driveignore doesn't seem to ignore "/Google Photos" #328

Closed
twstdpear opened this issue Aug 6, 2015 · 5 comments
Closed

.driveignore doesn't seem to ignore "/Google Photos" #328

twstdpear opened this issue Aug 6, 2015 · 5 comments
Assignees
@odeke-em
Labels
bug
Milestone
v0.2.8

Comments

@twstdpear
Copy link

Now that Google makes your photos available in Drive, I don't want to use "drive" to sync my "Google Photos" directory.

$ drive version
drive version: 0.2.7
Commit Hash: <CURRENT_COMMIT>
Go Version: <GO_VERSION>
OS: <OS_INFO>
BuildTime:

This works as expected:

$ mkdir "Dir Space"
$ touch "Dir Space"/a
$ echo /Dir Space > .driveignore
$ drive push Dir\ Space
Resolving...
'/Dir Space' is set to be ignored yet is being processed. Use force to override this

A plain "drive push" also properly ignores "/Dir Space". I can't show it here because of the issue below, but I verified it didn't show up in the list of proposed changes. So, I don't seem to be doing anything stupid with regard to .driveignore.

The behavior changes when working with "Google Photos"

$ echo /Google Photos > .driveignore
$ drive push "Google Photos"
Resolving...
'/Google Photos' is set to be ignored yet is being processed. Use force to override this

So far, so good.

However, a plain "drive push" wants to delete everything in /Google Photos directory on the remote.

$ drive push
Resolving...

  • /Google Photos
    ...
  • /Google Photos/2015
  • /Google Photos/2015/07
  • /Google Photos/2015/07/IMG_1108.JPG
    ...
  • /Google Photos/2003/12/img_0060.jpg
  • /Google Photos/2003/12/img_0068.jpg
    Deletion count 5826 dest: 7.61GB
    Proceed with the changes? [Y/n]:n

"drive pull" has similar behavior to "drive push" in all cases.
@odeke-em
Copy link
Owner

odeke-em commented Aug 6, 2015

Hello @twstdpear, welcome to drive and thank you for reporting this issue.

When I get back home in about 7 hours, I'll take a look at it.

@odeke-em odeke-em mentioned this issue Aug 11, 2015
Merged
@odeke-em odeke-em added the bug label Aug 11, 2015
@odeke-em odeke-em added this to the v0.2.8 milestone Aug 11, 2015
@odeke-em odeke-em self-assigned this Aug 11, 2015
@odeke-em
Copy link
Owner

Please get the latest from master. Addressed by #336.
You can get the latest from master by

$ go get -u github.com/odeke-em/drive/drive-gen && drive-gen

@odeke-em
Copy link
Owner

Filing a new release in a bit, so closing this in a bit.

@odeke-em
Copy link
Owner

Addressed by PR #336, closing it. Please re-open if it persists. Thank you for reporting this issue!

@twstdpear
Copy link
Author

Sorry for the delay in testing.
Confirmed that it fixes my issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

Labels
bug
Projects
None yet
Milestone
v0.2.8
Development

No branches or pull requests
2 participants
@odeke-em @twstdpear