You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears that when using the yearly period time format, datas are still displayed according to their months.
I've been creating a PR that fix the problem:
by setting month and day to 1 and 1 by default if you choose the yearly period (those ones are not relevant when datas are displayed by years)
and by using the DATE_FORMAT doctrine function (instead of DATE) (need to be import by the user in his doctrine.yaml file). The date format is passed as a parameter of the query builder. I've defined the three formats in the DataFetcher\Data class as constants, and created a function that returns the format according to what it receives in the configuration.
The two screenshots here shows how the plugin is working now:
It appears that when using the yearly period time format, datas are still displayed according to their months.
I've been creating a PR that fix the problem:
The two screenshots here shows how the plugin is working now:
![image](https://private-user-images.githubusercontent.com/82578062/330118325-97428fc6-2412-4d34-b326-41ab05329efa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTM4NzksIm5iZiI6MTcxOTM1MzU3OSwicGF0aCI6Ii84MjU3ODA2Mi8zMzAxMTgzMjUtOTc0MjhmYzYtMjQxMi00ZDM0LWIzMjYtNDFhYjA1MzI5ZWZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIyMTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3MzM1OGU4NTIxOTcwOGJjY2U1OTRhYzcwNWI5Mzg4NzlmNWQ2MTQyMTA5MDg1YjNiODIzYjdmY2RmOTMxMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ebw8fp4FYRgxu7HmH77akhg6fmk3Ecy6QDtQa8uLCy4)
![image](https://private-user-images.githubusercontent.com/82578062/330118356-9cd703b1-a723-463c-ba11-2560d7895c28.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTM4NzksIm5iZiI6MTcxOTM1MzU3OSwicGF0aCI6Ii84MjU3ODA2Mi8zMzAxMTgzNTYtOWNkNzAzYjEtYTcyMy00NjNjLWJhMTEtMjU2MGQ3ODk1YzI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIyMTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxNWZhNWNmNmQyNzYxYzY5MTQ3ODg4OTZlNWMwNGE3Y2JkYWM1OTY5NjliMGIzY2NlNjUyZDI2Mzg2Yjk5NmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.v0MTw7m_NOnxux5MZl507MYzBuXy2aelNgEMMIgJDoM)
And here find how it works with the fixes:
![image](https://private-user-images.githubusercontent.com/82578062/330118744-aae1dc4c-7db2-426c-b7a7-981115185fcb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTM4NzksIm5iZiI6MTcxOTM1MzU3OSwicGF0aCI6Ii84MjU3ODA2Mi8zMzAxMTg3NDQtYWFlMWRjNGMtN2RiMi00MjZjLWI3YTctOTgxMTE1MTg1ZmNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIyMTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY3ZTBkODIyNjRjNzc5MDkxNWFjMGVlMGMzODFkZmM5MmE4MWExY2I0ZmIyMzFlYzcyYWQ2NGQ2ZGNlNjVkYzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QFG_DYWeu1IdX7wLp4WGAfS7gFpish3iPJB1qIeSdt0)
![image](https://private-user-images.githubusercontent.com/82578062/330118524-e58d7317-5352-4984-a3a2-6f7a7b51aaf4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTM4NzksIm5iZiI6MTcxOTM1MzU3OSwicGF0aCI6Ii84MjU3ODA2Mi8zMzAxMTg1MjQtZTU4ZDczMTctNTM1Mi00OTg0LWEzYTItNmY3YTdiNTFhYWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIyMTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwMWI2Y2QwNzZlNzlmYjYzM2VlYjM2ZWYxZjUyYzY0ODc0MGI2OTk1MDRkMjFmYTNiMzY1MDg2OTU3MTBlODMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EI4zGF7VdIzded-n2hYdvUUoxsXB9Uzu_EHBAGs9xE8)
Here is the link to the PR: #23
I remain available here to answer any questions or to discuss the choices I've made.
The text was updated successfully, but these errors were encountered: