Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all features work in Pandoc >= v2.15. #4

Open
odkr opened this issue Nov 10, 2021 · 7 comments
Open

Not all features work in Pandoc >= v2.15. #4

odkr opened this issue Nov 10, 2021 · 7 comments

Comments

@odkr
Copy link
Owner

odkr commented Nov 10, 2021

I’ve posted this issue simply to let you know that I know. I’ll fix it soon-ish, promise.

@reagle
Copy link

reagle commented Dec 8, 2021

Argh... just bumped into it myself. Looking forward to fix.

@gwselke
Copy link

gwselke commented Jan 27, 2022

Dunno whether this is what you meant:
https://groups.google.com/g/pandoc-discuss/c/MiRomndx2H0 basically says that some undocumented API has gone away. The fix is fortunately easy:
In function insert_quot_marks change the second and third line to
local quote_type = quoted.quotetype
local inlines = quoted.content

@lu-p-us lu-p-us mentioned this issue Apr 15, 2022
@odkr odkr closed this as completed in c16e245 Apr 16, 2022
@odkr odkr changed the title Doesn’t work for Pandoc >= v2.15. Not all features work in Pandoc >= v2.15. Apr 16, 2022
@odkr
Copy link
Owner Author

odkr commented Apr 16, 2022

@L--U--P--U--S, thanks for the PR!

And sorry that this is taking so long. But some of the more obscure features of the filter also stopped working because of the many API changes that happened from Pandoc v2.15 to v2.17. I also want to support multilingual documents. So, @L--U--P--U--S was so kind to fix the function that most people use. I'll release a new version once the obscure features, too, work again ;-). For the time being, just download pandoc-quotes.lua from the main branch.

@odkr odkr reopened this Apr 16, 2022
@RLesur
Copy link
Contributor

RLesur commented Jun 4, 2022

I only use a subset of the features available in this filter and opened #6 to fix some issues.

@JohnCWood
Copy link

Hi: I am running into an issue with running pandoc-quotes.lua when trying to define quotes in yaml in pandoc 2.18. I tried running the test and the same errors seem to be coming up when running, e.g., test-simple.md:

Error running filter /home/john/.pandoc/filters/pandoc-quotes.lua: /home/john/.pandoc/filters/pandoc-quotes.lua:344: attempt to index a nil value (global 'string') stack traceback: /home/john/.pandoc/filters/pandoc-quotes.lua:421: in function </home/john/.pandoc/filters/pandoc-quotes.lua:404>
Is this related to the above problems referred to here?

Thanks for trying to get a new version together!

@reagle
Copy link

reagle commented Jun 28, 2022

I encountered an issue last week and downloaded the latest from github and the problem resolved.

@JohnCWood
Copy link

Oh, thanks very much! I thought I was using the latest version, but using the newest one seems to have solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants