Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 #1335

Closed
25 tasks done
kohr-h opened this issue May 3, 2018 · 8 comments
Closed
25 tasks done

Release 0.7.0 #1335

kohr-h opened this issue May 3, 2018 · 8 comments

Comments

@kohr-h
Copy link
Member

kohr-h commented May 3, 2018

It's been quite a while since the last release, and it seems like still a while to go until 1.0, since there are a bunch of quite big and important changes still to be finalized and merged. See #1055.

So how about we release once before, say 0.9.0, with roughly the current status? I also seem to remember that there were some changes in the conda build process that need to be done, and we don't want to screw up 1.0 for that reason.

Edit: I'll start with this and maintain a checklist here that reflects the process outlined in the release documentation.

  • 1. Agree on a release schedule
    • Open an issue on the issue tracker using the title "Release 0.7.0"
    • Discuss and agree on a set of open PRs that should be merged and issues that should be resolved before making a release
  • 2. Make sure tests succeed (including large-scale tests) and docs are built properly
  • 3. Make a release branch release-0.7.0 off master, on a fork like for any other PR
  • 4. Bump the master branch to the next development version (here '1.0.0.dev0')
    • odl/__init__.py
    • conda/meta.yaml
    • Make a PR and merge it
  • 5. Compile and publish the release
    • Compile the release notes with user-visible changes
    • Increment the version number to '0.7.0' in odl/__init__.py and conda/meta.yaml
    • Change the git_rev field in conda/meta.yaml to 'v0.7.0'
    • Make a PR and fix review comments, using a single commit REL: bump version to 0.7.0 Done on master
    • Push the release branch to the main repository
    • Draft a new release on GitHub using the the release-0.7.0 branch and the short summary from the release notes file; add a link to the release notes page
  • 6. Create packages for PyPI and Conda
  • 7. Test installing the local packages and check them
    • From source
    • From wheel
    • From conda package
  • 8. Upload the packages to the official locations
  • 9. Merge the release branch Not merging
@aringh
Copy link
Member

aringh commented May 3, 2018

I was looking at this only a few weeks ago, and I agree that a release before the 1.0 release could be nice. We have a lot of new things since last release, but indeed there seems to be a bit left before 1.0.

Edit: we seem to have changes in over 400 files, with over 40 000 additions and 19 000 deletions...

@adler-j
Copy link
Member

adler-j commented May 3, 2018

I agree that we should do this, but the version would be 0.7 according to standard numbering.

Do we have a list of things we want done here?

@kohr-h
Copy link
Member Author

kohr-h commented May 3, 2018

I'd suggest we only put stuff here that we can fix in relatively short time. Here's a list, feel free to edit:

PRs

The others are more fundamental or need significant work as far as I can judge.

Open issues

@adler-j
Copy link
Member

adler-j commented May 3, 2018

That does look like a reasonable release schedule. For 1.0 we want tensor valued discrete lp as well as a cuda backend.

@kohr-h kohr-h changed the title Release before 1.0? Release 0.7 May 3, 2018
@kohr-h kohr-h mentioned this issue Aug 22, 2018
4 tasks
@kohr-h
Copy link
Member Author

kohr-h commented Aug 31, 2018

I'll go ahead with this.

@kohr-h kohr-h self-assigned this Aug 31, 2018
@kohr-h kohr-h changed the title Release 0.7 Release 0.7.0 Sep 1, 2018
@kohr-h
Copy link
Member Author

kohr-h commented Sep 9, 2018

Done.

@kohr-h kohr-h closed this as completed Sep 9, 2018
@adler-j
Copy link
Member

adler-j commented Sep 10, 2018

Freaking tremendous and "done" does not sufficiently convey the success :) Now lets put our aims towards a proper 1.0 release (and getting an article out as well).

Btw, what happened to: #1432

@kohr-h
Copy link
Member Author

kohr-h commented Sep 10, 2018

Btw, what happened to: #1432

That'll go in as a regular PR on master, tonight if it gets approval in time 😉
I'll copy over the "highlights" from the release page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants