-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiarchitecture support (arm, arm64) #376
Comments
Anything particular is needed for arm support? I wouldn't mind adding arm support to my fork but I have no way to try this out. |
Tehnically you only need to make multi-architecture images of it. |
From what I could gather, there is no "multi arch" image but more or less multiple images on the same tag through a multi manifest. It doesn't seem to be possible to easily cross compile an arm image from amd64. So I'd need a VM or an actual device with ARM to build the images myself... Maybe docker hub is smart enough to select a build server on arm based on the docker file. I'll have to try that. Otherwise I just can't seem to build it. |
Docker hub's automated builder is not smart enough, and thus cannot build other architecture images. |
Hmm but I think my issue is a bit different...
I'll have to remove wkhtmltopdf as there are no arm build as far as I know. That said, I do have a wkhtmltopdf server that can be used transparently to point to a remote pdf server... that's a possibility to use as replacement for pdf. Edit: There is 0.12.6r1 |
Umm, it sounds like youre trying to build it incorrectly. You need to use Docker's buildx functionality most likely. |
Hmm okay, I'll have to update my build script to use buildx but I think it should work transparently. I have a proof of concept that downloads the proper deb file for wkhtmltox. |
I made this change to original image. And it works. https://hub.docker.com/r/wbms/odoo14-multiarch Build command: |
I've got some progress on that btw, the only small issue is mainly that for some reasons docker buildx doesnt want to push to a private repository... I haven't figured out why yet but it's also possible to work with other versions than 0.12.6-1 I'm finishing how to improve the version selection of wkhtmltopdf to install and then I think I'll be able to push the docker images in multi arch once I get buildx to push images. |
It would be really nice if this is will be in the official image. Is there any plans to do so? |
I am using the odoo 15.0, modified the dockerfile similar to this and built it. |
Multi architecture support is also made possible with merge request #399. |
Thanks for this. I'm using this approach to workaround the And building for both platforms using https://github.com/iterativo-git/dockerdoo/blob/13.0/.github/workflows/tests.yaml#L138 |
Let me throw one more option into the ring: separate images for arm ( #410 ) Tested on a M1 and it seems to work |
Let's see if this gets merged: |
This docker image needs multi-architecture builds so that it can be run on other architecture as well.
The text was updated successfully, but these errors were encountered: