Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readonly user has no permissions on hero_search table #2599

Closed
JacekLach opened this issue Sep 9, 2022 · 1 comment
Closed

readonly user has no permissions on hero_search table #2599

JacekLach opened this issue Sep 9, 2022 · 1 comment

Comments

@JacekLach
Copy link

The hero_search table (

CREATE TABLE IF NOT EXISTS hero_search (
) is not in the list of grants (

core/sql/create_tables.sql

Lines 520 to 536 in 5a9ea64

IF EXISTS (SELECT 1 FROM pg_roles WHERE rolname = 'readonly') THEN
GRANT SELECT ON matches TO readonly;
GRANT SELECT ON player_matches TO readonly;
GRANT SELECT ON heroes TO readonly;
GRANT SELECT ON leagues TO readonly;
GRANT SELECT ON items TO readonly;
GRANT SELECT ON teams TO readonly;
GRANT SELECT ON team_match TO readonly;
GRANT SELECT ON match_patch TO readonly;
GRANT SELECT ON picks_bans TO readonly;
GRANT SELECT ON match_logs TO readonly;
GRANT SELECT ON notable_players TO readonly;
GRANT SELECT ON public_matches TO readonly;
GRANT SELECT ON public_player_matches TO readonly;
GRANT SELECT ON players TO readonly;
GRANT SELECT ON team_rating TO readonly;
END IF;
)

I assume this is why it is not available to be queried in the data explorer:

image

The current combo search is not very useful for anyone trying to learn, as it'll usually return you very low mmr matches. Being able to sort by mmr, or fiter to some bracket at least, would be huge improvement.

@howardchung
Copy link
Member

This is a pretty big table and there might be perf issues with allow free querying on it, so only some specific tables have this enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants