Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Peers" view shows next button even when user has <20 peers #122

Closed
cannawen opened this issue Mar 14, 2018 · 4 comments
Closed

"Peers" view shows next button even when user has <20 peers #122

cannawen opened this issue Mar 14, 2018 · 4 comments

Comments

@cannawen
Copy link
Contributor

Expected: "Peers" view should not show next button when there is no next page
Actual: "Peers" view shows next button even when user has <20 peers

Screenshots from my device:
screenshot_20180314-083753
screenshot_20180314-083800

@cannawen
Copy link
Contributor Author

cannawen commented Mar 14, 2018

I imagine something like #123 would fix it (not tested, I wasn't able to get the app to compile lol).

Looking at the code though, I think it would make sense to factor out the nextControl/previousControl into its own component. Then you can pass it props for:

  1. if it's enabled
  2. left or right navigation

and it might make the code easier to reason with. And it can also be reused for other pages (Heros and Matches)

@cannawen
Copy link
Contributor Author

Tested the fix on iOS sim (wasn't compiling on Android for whatever reason), looks ok. There's probably a similar issue with <20 matches though.

screen shot 2018-03-14 at 10 50 51 am

@Proyoyo
Copy link
Contributor

Proyoyo commented Mar 14, 2018

@cannawen Merged. Do you want to create a new issue for the nextControl/previousControl refactoring? The same issue exist on Matches page as well.

@cannawen
Copy link
Contributor Author

I'll create some new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants