Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deterministic for affine expr with no terms #297

Merged
merged 4 commits into from Jan 23, 2020
Merged

Fix deterministic for affine expr with no terms #297

merged 4 commits into from Jan 23, 2020

Conversation

odow
Copy link
Owner

@odow odow commented Jan 23, 2020

cc @haoxiangyang89

This fixes the "K not defined." But we still throw on:

ERROR: Unable to formulate deterministic equivalent: `copy_and_replace_variables` is not implemented for functions like `-d[1]*G[1] + 0.5 d[1]*s[1,1] + t[0]_out - t[1]_out + 2.5 x[1,1]_out`.

because I didn't address quadratics yet.

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #297 into master will decrease coverage by 0.26%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   93.82%   93.56%   -0.27%     
==========================================
  Files          20       20              
  Lines        1685     1693       +8     
==========================================
+ Hits         1581     1584       +3     
- Misses        104      109       +5
Impacted Files Coverage Δ
src/deterministic_equivalent.jl 94.28% <50%> (-4.69%) ⬇️
src/algorithm.jl 97.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d236c...bf3b846. Read the comment docs.

@odow
Copy link
Owner Author

odow commented Jan 23, 2020

Something weird is going on with coverage at the moment, because every line is hit, but it's marking the line below the hit line as missing... Merging even with the red x's.

@odow odow merged commit 254b47c into master Jan 23, 2020
@odow odow deleted the odow-patch-2 branch January 23, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant