New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Large refactoring of stochastic integer programs #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
force-pushed
the
od/sddip
branch
3 times, most recently
from
August 15, 2021 09:50
a53767d
to
481105c
Compare
is solved on the forward pass.
odow
force-pushed
the
od/sddip
branch
2 times, most recently
from
August 16, 2021 02:30
c409fd1
to
a22bacf
Compare
In particular - Automatic binarization removed - States no longer assumed to be binary - setup_state removed - better tests added - better documentation added
odow
commented
Aug 16, 2021
function _deprecate_integrality_handler() | ||
return error( | ||
""" | ||
SDDP.jl v0.4.0 introduced a number of breaking changes in how we deal with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lkapelevich
odow
changed the title
[breaking] begin refactoring of SMIP stuff
[breaking] Large refactoring of stochastic integer programs
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a breaking PR for how we handle stochastic integer programs. I'm not in a rush to merge this so I plan on doing a big reorganization.
Plan of attack:
ContinuousRelaxation
toConicDuality
SDDiP
to LagrangianDuality`StrengthenedConicDuality
integrality_handler
and let SDDP.jl decide when to try different dual cutsCloses #431