Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Large refactoring of stochastic integer programs #449

Merged
merged 17 commits into from Aug 16, 2021
Merged

Conversation

odow
Copy link
Owner

@odow odow commented Aug 15, 2021

This is the start of a breaking PR for how we handle stochastic integer programs. I'm not in a rush to merge this so I plan on doing a big reorganization.

Plan of attack:

  • Use integers on the forward pass
  • Rename ContinuousRelaxation to ConicDuality
  • Rename SDDiP to LagrangianDuality`
  • Add StrengthenedConicDuality
  • Remove integrality_handler and let SDDP.jl decide when to try different dual cuts
  • Remove automatic binarization and modify Kelley's as appropriate to accommodate non-binary states

Closes #431

@odow odow added the stochastic-integer Related to stochastic mixed-integer programs label Aug 15, 2021
@odow odow force-pushed the od/sddip branch 3 times, most recently from a53767d to 481105c Compare August 15, 2021 09:50
@odow odow force-pushed the od/sddip branch 2 times, most recently from c409fd1 to a22bacf Compare August 16, 2021 02:30
In particular
 - Automatic binarization removed
 - States no longer assumed to be binary
 - setup_state removed
 - better tests added
 - better documentation added
function _deprecate_integrality_handler()
return error(
"""
SDDP.jl v0.4.0 introduced a number of breaking changes in how we deal with
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow odow changed the title [breaking] begin refactoring of SMIP stuff [breaking] Large refactoring of stochastic integer programs Aug 16, 2021
@odow odow added the breaking label Aug 16, 2021
@odow odow merged commit 691ac2d into master Aug 16, 2021
@odow odow deleted the od/sddip branch August 16, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking stochastic-integer Related to stochastic mixed-integer programs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use integer forward pass
1 participant