Fix caching state bug in cyclic forward passes #547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there was a very subtle bug in the implementation of the cyclic state-drop-off logic. We should be storing the outgoing state of the second-to-last node (which will be the incoming state of the node that forms a cycle), not the outgoing state of the node that forms a cycle.
Then JADE should use historical inflows which are 52weeks + 1week long and things should work by default.
We could potentially improve things by removing the
splice!
, so that we build up a distribution of starting states, not the trajectory over time.Closes #445