Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DOCUMENTER_KEY to deploy docs #670

Merged
merged 1 commit into from Sep 21, 2023
Merged

Use DOCUMENTER_KEY to deploy docs #670

merged 1 commit into from Sep 21, 2023

Conversation

odow
Copy link
Owner

@odow odow commented Sep 21, 2023

Actions which use GITHUB_TOKEN can't themselves trigger new actions:
https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

So if we upload the docs with GITHUB_TOKEN, it doesn't then trigger the push notification for the deploy-static action.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a1c402) 92.71% compared to head (7ba39f6) 92.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          27       27           
  Lines        3334     3334           
=======================================
  Hits         3091     3091           
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 12ba11e into master Sep 21, 2023
8 checks passed
@odow odow deleted the odow-patch-1 branch September 21, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant