Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include asset's owners info in response #218

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Mar 1, 2023

When assets are sinked to Compass from Meteor, the UUID is not populated for the asset owners. This meant that fetching the asset either by ID or while listing the assets, the owner info (email) was not being returned because of a filter condition on UUID.

Include the owner's information available in the datastore irrespective of whether UUID was populated or not.

Closes #186

When assets are sinked to Compass from Meteor, the UUID is not populated
for the asset owners. This meant that fetching the asset either by ID or
while listing the assets, the owner info (email) was not being returned
because of a filter condition on UUID.

Include the owner's information available in the datastore irrespective
of whether UUID was populated or not.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4301602153

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 86.142%

Totals Coverage Status
Change from base Build 4239395612: 0.03%
Covered Lines: 5010
Relevant Lines: 5816

💛 - Coveralls

@sudo-suhas sudo-suhas merged commit 65b8328 into main Mar 3, 2023
@sudo-suhas sudo-suhas deleted the fix-asset-owners-resp branch March 3, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets fetching APIs returning empty owners info
3 participants