Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker compose for dagger quickstart #206

Merged
merged 31 commits into from Oct 31, 2022
Merged

feat: docker compose for dagger quickstart #206

merged 31 commits into from Oct 31, 2022

Conversation

sumitaich1998
Copy link
Contributor

@sumitaich1998 sumitaich1998 commented Oct 20, 2022

fixes #207

Acceptance Criteria:

GIVEN WHEN THEN
Jack is a new user who wants to try out Dagger locally quickly, AND,Jack doesn’t want to do any complex installation of dependencies like Kafka or Apache Flink locally Jack runs the Docker Compose file by executing docker compose up in the directory containing the docker compose file Run Dagger jar in a containerA local kafka cluster should be setup with just one broker containerA kafka producer container should be spawned which continuosly produces messages to some source Kafka topicA bare minimum dagger job with just a 30 sec aggregateSQL query should get submitted to the local Flink cluster with both source and sink as KafkaThe dagger should continue to consume messages from the source topic and publish messages to the sink topic until Jack explicitly executes docker compose down
Jack is a new user who wants to try out Dagger locally quickly, AND,Jack doesn’t want to do any complex installation of dependencies like Kafka or Apache Flink locally Jack runs the Docker Compose file by executing docker compose down in the directory containing the docker compose file All the spawned containers: Dagger, Kafka, etc should be closed down gracefully.

@sumitaich1998 sumitaich1998 self-assigned this Oct 20, 2022
@sumitaich1998 sumitaich1998 marked this pull request as ready for review October 20, 2022 13:00
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/resources/sample_message.txt Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
@Meghajit
Copy link
Member

Meghajit commented Oct 26, 2022

@sumitaich1998 Some feedback:

  1. Let's name the topmost folder as quickstart instead of quickstart-docker.
    This folder will house other resources as well in the future stories and not just the docker compose file. We can create a nested folder called as docker-compose and place the related files inside

  2. I think this was missed in the ACs. But we would need to link this docker compose setup in the documentation. Can you mention a link to this file in: the landing page README here + in the quickstart documentation here

quickstart-docker/resources/local.properties Outdated Show resolved Hide resolved
quickstart-docker/resources/TestMessage.proto Outdated Show resolved Hide resolved
quickstart-docker/resources/TestLogMessage.proto Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
quickstart-docker/compose.yaml Outdated Show resolved Hide resolved
yes Y | add-apt-repository universe
yes Y | apt-get update
yes Y | apt-get install protobuf-compiler
yes Y | apt-get install kafkacat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit version of kafkacat need to be installed to maintain compatiblity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

quickstart-docker/resources/kafkafeeder.sh Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dagger ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 10:55AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker compose setup for dagger quickstart
3 participants