feat: add S3 sink support #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavkesh
reviewed
Feb 22, 2022
lavkesh
reviewed
Feb 22, 2022
|
@lavkesh Also out of scope of this PR, but we can also bring S3 and GCS specific logic to sink root instead of it staying in common package. |
lavkesh
reviewed
Feb 22, 2022
src/main/java/io/odpf/firehose/sink/common/blobstorage/BlobStorageFactory.java
Outdated
Show resolved
Hide resolved
lavkesh
reviewed
Feb 22, 2022
src/main/java/io/odpf/firehose/sink/common/blobstorage/s3/S3.java
Outdated
Show resolved
Hide resolved
@ravisuhag Blob is needed for DLQ too, that's why we have in common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Please describe what you added, and add a screenshot if possible.
faster.
That makes it easier to understand the change so we can
✔️ Checklist