fix: prom sink changed to PoolingHttpClientConnectionManager for idle connection eviction #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection eviction
…lingHttpClientConnectionManager
|
@lavkesh - Can we merge this PR? |
lavkesh
approved these changes
Oct 27, 2022
sumitaich1998
added a commit
that referenced
this pull request
Oct 31, 2022
… connection eviction (#195) (#197) * fix: prom sink changed to BasicHttpClientConnectionManager for idle connection eviction * fix: update default SINK_PROM_MAX_CONNECTIONS * fix: changed default value for max prom connection to use default PoolingHttpClientConnectionManager * fix: styling * fix: added default value in doc Co-authored-by: Mayank Rai <mayank.rai@gojek.com> Co-authored-by: Mayank Rai <92782366+mayankrai09@users.noreply.github.com> Co-authored-by: Mayank Rai <mayank.rai@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently started using Prom Sink, We are seeing NoHttpResponseException in log-
2022-09-28T12:20:59,632Z [pool-2-thread-1] WARN i.o.f.sink.prometheus.PromSink - caught class org.apache.http.NoHttpResponseException p-gopaydata-id-radar-router.gtfdata.io:80 failed to respond 2022-09-28T12:20:59,632Z [pool-2-thread-1] WARN i.o.f.sink.prometheus.PromSink - xxxxxxxxxxxxxxx.gtfdata.io:80 failed to respond org.apache.http.NoHttpResponseException: xxxxxxxxxxxxxxxxxx.gtfdata.io:80 failed to respond at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141) at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56) at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259) at org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163) at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273) at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)Fix - PoolingHttpClientConnectionManager will evict partially closed connection by default.