chore: address review comments

raystack · Jul 18, 2022 · 4833cce · 4833cce
1 parent e210324
commit 4833cce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/appeal/service.go b/core/appeal/service.go
@@ -82,7 +82,7 @@ type createAppealOptions struct {
 	IsAdditionalAppeal bool
 }
 
-func WithAdditionalAppealOption() CreateAppealOption {
+func CreateWithAdditionalAppeal() CreateAppealOption {
 	return func(opts *createAppealOptions) {
 		opts.IsAdditionalAppeal = true
 	}
@@ -800,7 +800,7 @@ func (s *Service) handleAppealRequirements(ctx context.Context, a *domain.Appeal
 					additionalAppeal.PolicyID = aa.Policy.ID
 					additionalAppeal.PolicyVersion = uint(aa.Policy.Version)
 				}
-				if err := s.Create(ctx, []*domain.Appeal{additionalAppeal}, WithAdditionalAppealOption()); err != nil {
+				if err := s.Create(ctx, []*domain.Appeal{additionalAppeal}, CreateWithAdditionalAppeal()); err != nil {
 					if errors.Is(err, ErrAppealDuplicate) {
 						continue
 					}

diff --git a/core/appeal/service_test.go b/core/appeal/service_test.go
@@ -839,7 +839,7 @@ func (s *ServiceTestSuite) TestCreate() {
 			s.mockNotifier.On("Notify", mock.Anything).Return(nil).Once()
 			s.mockAuditLogger.On("Log", mock.Anything, appeal.AuditKeyBulkInsert, mock.Anything).Return(nil).Once()
 
-			err := s.service.Create(context.TODO(), []*domain.Appeal{input}, appeal.WithAdditionalAppealOption())
+			err := s.service.Create(context.Background(), []*domain.Appeal{input}, appeal.CreateWithAdditionalAppeal())
 
 			s.NoError(err)
 			s.Equal("test-approval", input.Approvals[0].Name)