refactor: make slackIDCache private to slack client

raystack · Mar 7, 2023 · c997dba · c997dba
1 parent 8907769
commit c997dba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/plugins/notifiers/client.go b/plugins/notifiers/client.go
@@ -34,8 +34,7 @@ func NewClient(config *Config) (Client, error) {
 			Messages:    config.Messages,
 		}
 		httpClient := &http.Client{Timeout: 10 * time.Second}
-		slackIDCache := map[string]string{}
-		return slack.NewNotifier(slackConfig, slackIDCache, httpClient), nil
+		return slack.NewNotifier(slackConfig, httpClient), nil
 	}
 
 	return nil, errors.New("invalid notifier provider type")

diff --git a/plugins/notifiers/slack/client.go b/plugins/notifiers/slack/client.go
@@ -49,10 +49,10 @@ type Config struct {
 //go:embed templates/*
 var defaultTemplates embed.FS
 
-func NewNotifier(config *Config, slackIDCache map[string]string, httpClient utils.HTTPClient) *Notifier {
+func NewNotifier(config *Config, httpClient utils.HTTPClient) *Notifier {
 	return &Notifier{
 		accessToken:         config.AccessToken,
-		slackIDCache:        slackIDCache,
+		slackIDCache:        map[string]string{},
 		Messages:            config.Messages,
 		httpClient:          httpClient,
 		defaultMessageFiles: defaultTemplates,

diff --git a/plugins/notifiers/slack/client_test.go b/plugins/notifiers/slack/client_test.go
@@ -19,7 +19,6 @@ type ClientTestSuite struct {
 	mockHttpClient *mocks.HTTPClient
 	accessToken    string
 	messages       domain.NotificationMessages
-	slackIDCache   map[string]string
 	notifier       *slack.Notifier
 }
 
@@ -29,14 +28,13 @@ func (s *ClientTestSuite) setup() {
 	s.messages = domain.NotificationMessages{
 		AppealRejected: "[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"Your appeal to {{.resource_name}} with role {{.role}} has been rejected\"}}]",
 	}
-	s.slackIDCache = map[string]string{}
 
 	conf := &slack.Config{
 		AccessToken: s.accessToken,
 		Messages:    s.messages,
 	}
 
-	s.notifier = slack.NewNotifier(conf, s.slackIDCache, s.mockHttpClient)
+	s.notifier = slack.NewNotifier(conf, s.mockHttpClient)
 }
 
 func (s *ClientTestSuite) TestNotify() {