Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use variadic options for appeal creation #222

Merged
merged 4 commits into from
Jul 19, 2022
Merged

feat: use variadic options for appeal creation #222

merged 4 commits into from
Jul 19, 2022

Conversation

bsushmith
Copy link
Member

Closes #221

@bsushmith bsushmith requested a review from mabdh July 18, 2022 07:28
@bsushmith bsushmith marked this pull request as ready for review July 18, 2022 07:35
@coveralls
Copy link

coveralls commented Jul 18, 2022 •
edited

Pull Request Test Coverage Report for Build 2689178291

  • 15 of 18 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 49.508%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 15 18 83.33%
Totals Coverage Status
Change from base Build 2686158792: 0.07%
Covered Lines: 3322
Relevant Lines: 6710
💛 - Coveralls

mabdh
mabdh reviewed Jul 18, 2022
View reviewed changes
core/appeal/service.go Outdated Show resolved Hide resolved
@mabdh mabdh self-requested a review July 19, 2022 05:32
@ravisuhag ravisuhag merged commit 5193a45 into main Jul 19, 2022
@ravisuhag ravisuhag deleted the review-changes branch July 19, 2022 05:37
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@sbchaos
refactor(optimus): update the api for backup to accept list of resour…
34e92f7 
…ces (raystack#222)

* refactor: update backup api to accept list of resources to backup

* fix: fix buf lint errors

* refactor: remove dry run api

* refactor: return the id for backup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd left review comments

@mabdh mabdh mabdh approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use variadic options instead of context to pass around additional appeal information
5 participants
@bsushmith @coveralls @mabdh @rahmatrhd @ravisuhag