Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gcs provider #227

Merged
merged 27 commits into from
Aug 10, 2022
Merged

feat: add gcs provider #227

merged 27 commits into from
Aug 10, 2022

Conversation

Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Jul 22, 2022 •
edited

Issue linked to this branch- #194
Summary
We need to support access management of GCS.

Proposed solution

  • Provider configuration for gcs
  • GCS client
  • GCS resource & access management
  • Documentation
  • Tests

@coveralls
Copy link

coveralls commented Jul 22, 2022 •
edited

Pull Request Test Coverage Report for Build 2823385830

  • 249 of 314 (79.3%) changed or added relevant lines in 4 files are covered.
  • 213 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.1%) to 75.937%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/gcs/resource.go 11 13 84.62%
plugins/providers/gcs/config.go 78 93 83.87%
plugins/providers/gcs/provider.go 137 159 86.16%
plugins/providers/gcs/client.go 23 49 46.94%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/grpc.go 1 90.91%
internal/store/postgres/appeal_repository.go 4 96.67%
api/handler/v1beta1/appeal.go 28 83.82%
core/appeal/service.go 180 57.36%
Totals Coverage Status
Change from base Build 2790641381: -1.1%
Covered Lines: 5551
Relevant Lines: 7310
💛 - Coveralls

@ravisuhag ravisuhag linked an issue Jul 25, 2022 that may be closed by this pull request
Add support for GCS provider #194
Closed
4 tasks
@Chief-Rishab Chief-Rishab self-assigned this Aug 2, 2022
@Chief-Rishab Chief-Rishab marked this pull request as ready for review August 3, 2022 11:46
mabdh
mabdh reviewed Aug 5, 2022
View reviewed changes
plugins/providers/gcs/client.go Show resolved Hide resolved
plugins/providers/gcs/config.go Show resolved Hide resolved
plugins/providers/gcs/config.go Outdated Show resolved Hide resolved
plugins/providers/gcs/config.go Outdated Show resolved Hide resolved
plugins/providers/gcs/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcs/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcs/provider.go Outdated Show resolved Hide resolved
mabdh
mabdh reviewed Aug 5, 2022
View reviewed changes
plugins/providers/gcs/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcs/client.go Outdated Show resolved Hide resolved
plugins/providers/gcs/client.go Outdated Show resolved Hide resolved
plugins/providers/gcs/client.go Outdated Show resolved Hide resolved
plugins/providers/gcs/resource.go Show resolved Hide resolved
rahmatrhd
rahmatrhd requested changes Aug 9, 2022
View reviewed changes
plugins/providers/gcs/config.go Outdated Show resolved Hide resolved
plugins/providers/gcs/provider.go Outdated Show resolved Hide resolved
rahmatrhd
rahmatrhd approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravisuhag ravisuhag merged commit 4765cff into main Aug 10, 2022
@ravisuhag ravisuhag deleted the add-gcs-provider branch August 10, 2022 08:58
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@krtkvrm
feat: change type of status from string to bool (raystack#227)
3e0881e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

Assignees

@Chief-Rishab Chief-Rishab

Labels
gcs provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for GCS provider
5 participants
@Chief-Rishab @coveralls @mabdh @rahmatrhd @ravisuhag