Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow appeal for other user configurable in policy #244

Merged
merged 9 commits into from
Sep 15, 2022
Merged

feat: allow appeal for other user configurable in policy #244

merged 9 commits into from
Sep 15, 2022

Conversation

singhvikash11
Copy link
Member

Implement #212: Appeal request on behalf of another user

@coveralls
Copy link

coveralls commented Aug 3, 2022 •
edited

Pull Request Test Coverage Report for Build 3058135432

  • 19 of 33 (57.58%) changed or added relevant lines in 2 files are covered.
  • 151 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+2.7%) to 76.286%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 18 32 56.25%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/grpc.go 1 91.3%
internal/store/postgres/approval_repository.go 3 92.86%
core/appeal/service.go 70 78.4%
api/handler/v1beta1/adapter.go 77 80.28%
Totals Coverage Status
Change from base Build 2945876610: 2.7%
Covered Lines: 5842
Relevant Lines: 7658
💛 - Coveralls

@ravisuhag ravisuhag linked an issue Aug 3, 2022 that may be closed by this pull request
Appeal request on behalf of other user #212
Closed
mabdh
mabdh reviewed Aug 10, 2022
View reviewed changes
core/appeal/service.go Outdated Show resolved Hide resolved
mabdh
mabdh reviewed Aug 10, 2022
View reviewed changes
domain/notifier.go Outdated Show resolved Hide resolved
bsushmith
bsushmith reviewed Aug 11, 2022
View reviewed changes
core/appeal/service.go Outdated Show resolved Hide resolved
mabdh
mabdh reviewed Aug 14, 2022
View reviewed changes
domain/notifier.go Outdated Show resolved Hide resolved
mabdh
mabdh reviewed Aug 14, 2022
View reviewed changes
domain/notifier.go Outdated Show resolved Hide resolved
bsushmith and others added 4 commits August 17, 2022 23:21
@bsushmith @mabdh
fix: update key name to be consistent
04b28a1 
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
@bsushmith @mabdh
docs: fix typo
9af7be4 
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
@bsushmith
refactor: rename variable for readability
000f250
@singhvikash11
chore: merge main branch and resolve conflict
1e55e42
rahmatrhd
rahmatrhd approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only small suggestion

core/appeal/service.go Outdated Show resolved Hide resolved
@ravisuhag @rahmatrhd
Update core/appeal/service.go
d6eebb2 
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
@ravisuhag ravisuhag merged commit 1f8270b into main Sep 15, 2022
@ravisuhag ravisuhag deleted the allow_cross_user_appeal branch September 15, 2022 06:02
rahmatrhd added a commit that referenced this pull request Sep 26, 2022
@singhvikash11 @bsushmith
@mabdh @ravisuhag @rahmatrhd
feat: allow appeal for other user configurable in policy (#244)
c4f7809 
* feat: allow appeal for other user configurable in policy

* fix: Modified proto contract

* fix: resolve pr feedback

* fix: update key name to be consistent

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* docs: fix typo

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* refactor: rename variable for readability

* Update core/appeal/service.go

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
Co-authored-by: sushmith <bsushmith@live.com>
Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
haveiss pushed a commit that referenced this pull request Oct 21, 2022
@singhvikash11 @bsushmith
@mabdh @ravisuhag @rahmatrhd @haveiss
feat: allow appeal for other user configurable in policy (#244)
1922096 
* feat: allow appeal for other user configurable in policy

* fix: Modified proto contract

* fix: resolve pr feedback

* fix: update key name to be consistent

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* docs: fix typo

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* refactor: rename variable for readability

* Update core/appeal/service.go

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
Co-authored-by: sushmith <bsushmith@live.com>
Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
haveiss pushed a commit that referenced this pull request Oct 21, 2022
@singhvikash11 @bsushmith
@mabdh @ravisuhag @rahmatrhd @haveiss
feat: allow appeal for other user configurable in policy (#244)
aa550d4 
* feat: allow appeal for other user configurable in policy

* fix: Modified proto contract

* fix: resolve pr feedback

* fix: update key name to be consistent

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* docs: fix typo

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* refactor: rename variable for readability

* Update core/appeal/service.go

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
Co-authored-by: sushmith <bsushmith@live.com>
Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
ravisuhag added a commit that referenced this pull request Oct 21, 2022
@Chief-Rishab @singhvikash11
@bsushmith @mabdh @ravisuhag @rahmatrhd @haveiss
docs: update documentation (#269)
9fb4ff1 
* docs: add gcs and gcloud_iam in provider reference

* docs(api reference): update description and examples

* docs(introduction): add introduction to guardian cli and apis

* docs(tour): rename guides to tour and update reference links

* docs(bigquery): update bq resource details

* docs(gcloud): update gcloud resource details

* docs(grafana): update provider details

* docs(noop): add noop provider page

* docs(noop): add noop provider page

* docs: add jobs reference page

* docs: add jobs reference page

* docs: update api field descriptions

* docs: add gcs and gcloud_iam in provider reference

* docs(api reference): update description and examples

* docs(introduction): add introduction to guardian cli and apis

* docs(tour): rename guides to tour and update reference links

* docs(bigquery): update bq resource details

* docs(gcloud): update gcloud resource details

* docs(grafana): update provider details

* docs(noop): add noop provider page

* docs(noop): add noop provider page

* docs: add jobs reference page

* docs: add jobs reference page

* docs: update api field descriptions

* feat: allow appeal for other user configurable in policy (#244)

* feat: allow appeal for other user configurable in policy

* fix: Modified proto contract

* fix: resolve pr feedback

* fix: update key name to be consistent

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* docs: fix typo

Co-authored-by: Abduh <mabdh@users.noreply.github.com>

* refactor: rename variable for readability

* Update core/appeal/service.go

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
Co-authored-by: sushmith <bsushmith@live.com>
Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

* docs: add deployment with helm and docker

* docs: update gcs provider

Co-authored-by: Vikash Singh <vicky301186@gmail.com>
Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
Co-authored-by: sushmith <bsushmith@live.com>
Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
Co-authored-by: Haveiss <to@haveiss.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appeal request on behalf of other user
6 participants
@singhvikash11 @coveralls @mabdh @rahmatrhd @bsushmith @ravisuhag