Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use created_at, updated_at from appeals otherwise grants table loses the temporal order of access #294

Closed
wants to merge 1 commit into from

Conversation

singhvikash11
Copy link
Member

fix: use created_at, updated_at from appeals otherwise grants table loses the temporal order of access

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3133914303

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.32%

Totals Coverage Status
Change from base Build 3133215959: 0.0%
Covered Lines: 5853
Relevant Lines: 7669

💛 - Coveralls

@rahmatrhd
Copy link
Member

I think create/update history can still be referenced from the appeal by using appeal_id reference in grant

@singhvikash11
Copy link
Member Author

@rahmatrhd we could fetch temporal-order by joining with the appeal table however grants table will have these timestamps populated in case of access is approved for new records. So we need two different queries to find temporal order, one for records before migration and the other after migration.

@mabdh
Copy link
Member

mabdh commented Sep 27, 2022

@singhvikash11 is there any Github issue related with this? If yes can you please link it? If not, can you please create one and explain the context about the bug/changes?

@rahmatrhd rahmatrhd deleted the fix_migration_script branch October 3, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants