Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grant): fix is_permanent filter condition #303

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

rahmatrhd
Copy link
Member

@rahmatrhd rahmatrhd commented Oct 5, 2022

fixes an issue from recently merged PR #302:

  • list grants with filter is_permanent=false is not working because it's not passed in the repository

@coveralls
Copy link

coveralls commented Oct 5, 2022

Pull Request Test Coverage Report for Build 3188714944

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.673%

Totals Coverage Status
Change from base Build 3182535443: 0.0%
Covered Lines: 5900
Relevant Lines: 7695

💛 - Coveralls

@rahmatrhd rahmatrhd requested a review from mabdh October 5, 2022 09:24
@AkarshSatija AkarshSatija merged commit 947e354 into main Oct 5, 2022
@AkarshSatija AkarshSatija deleted the fix-grant-exp-date-2 branch October 5, 2022 11:54
haveiss pushed a commit that referenced this pull request Oct 21, 2022
* fix(grant): fix is_permanent filter condition

* add: add abduh as codeowner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants