Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grant): change guardian import access API #309

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Conversation

rahmatrhd
Copy link
Member

apply this change: raystack/proton@d9b61bb

@coveralls
Copy link

coveralls commented Oct 17, 2022

Pull Request Test Coverage Report for Build 3270563828

  • 16 of 27 (59.26%) changed or added relevant lines in 2 files are covered.
  • 144 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.013%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/grant/service.go 0 3 0.0%
api/handler/v1beta1/grant.go 16 24 66.67%
Files with Coverage Reduction New Missed Lines %
internal/store/postgres/policy_repository.go 6 78.85%
core/approval/service.go 10 75.0%
internal/store/postgres/approval_repository.go 10 88.37%
internal/store/postgres/resource_repository.go 11 84.89%
core/resource/service.go 12 45.35%
internal/store/postgres/appeal_repository.go 13 89.34%
internal/store/postgres/provider_repository.go 14 85.6%
core/policy/service.go 28 58.82%
core/provider/service.go 40 60.0%
Totals Coverage Status
Change from base Build 3240858092: 0.2%
Covered Lines: 5944
Relevant Lines: 8031

💛 - Coveralls

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Haveiss <haveiss@users.noreply.github.com>
@ravisuhag ravisuhag merged commit 075f577 into main Oct 18, 2022
@ravisuhag ravisuhag deleted the fix-import-access branch October 18, 2022 04:20
haveiss added a commit that referenced this pull request Oct 21, 2022
* fix(grant): change guardian import access API

* chore: rename ImportAccess to ImportFromProvider

* Update Makefile

Co-authored-by: Haveiss <haveiss@users.noreply.github.com>

Co-authored-by: Ravi Suhag <suhag.ravi@gmail.com>
Co-authored-by: Haveiss <haveiss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants