fix: fix grant revoke for deleted resource into guardian. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhvikash11
requested review from
ravisuhag,
rahmatrhd,
AkarshSatija and
mabdh
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 3478874498
💛 - Coveralls |
singhvikash11
force-pushed
the
fix_deleted_resource_revoke
branch
from
4da68c3
to
7afc70b
Compare
singhvikash11
force-pushed
the
fix_deleted_resource_revoke
branch
from
7afc70b
to
d028625
Compare
rahmatrhd
requested changes
Nov 21, 2022
Comment on lines
+1
to
+7
| UPDATE | ||
| "grants" | ||
| SET | ||
| "status_in_provider" = "status" | ||
| WHERE | ||
| "source" = 'appeal' | ||
| AND "status_in_provider" != "status" |
There was a problem hiding this comment.
if I assume it correctly this is for fixing the previously wrong-assigned data(?) If so, can we not do it through app migration but run this SQL fix in our running db instances directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #299