Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grant): fix import grants #351

Merged
merged 6 commits into from
Jan 20, 2023
Merged

fix(grant): fix import grants #351

merged 6 commits into from
Jan 20, 2023

Conversation

rahmatrhd
Copy link
Member

  • fix nil pointer exception
  • keep list grants and list resources matching with the import criteria
  • add test cases

@coveralls
Copy link

coveralls commented Jan 20, 2023 •
edited

Pull Request Test Coverage Report for Build 3966569827

  • 51 of 59 (86.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 73.623%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/grant/service.go 33 35 94.29%
domain/grant.go 0 6 0.0%
Totals Coverage Status
Change from base Build 3955707118: 1.1%
Covered Lines: 7472
Relevant Lines: 10149
💛 - Coveralls

@ravisuhag ravisuhag merged commit edc6df6 into main Jan 20, 2023
@ravisuhag ravisuhag deleted the release-v0.5.3 branch January 20, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haveiss haveiss haveiss approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rahmatrhd @coveralls @haveiss @ravisuhag