Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump salt config version #353

Merged
merged 1 commit into from
Jan 27, 2023
Merged

feat: bump salt config version #353

merged 1 commit into from
Jan 27, 2023

Conversation

haveiss
Copy link
Contributor

@haveiss haveiss commented Jan 27, 2023

Context

rahmatrhd
rahmatrhd approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wait until the salt PR is merged into main and then bump to that version?

@haveiss
Copy link
Contributor Author

haveiss commented Jan 27, 2023 •
edited

should we wait until the salt PR is merged into main and then bump to that version?

latest salt version are breaking changes raystack/salt#63, it requires to make changes, let's do that on separate PR, meanwhile we can use rebase version that already cover the env variable issue, wdyt @rahmatrhd ?

@haveiss haveiss merged commit a01bb09 into main Jan 27, 2023
@haveiss haveiss deleted the feat/upgrade-salt branch January 27, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haveiss @rahmatrhd