Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify job builders #734

Merged
merged 2 commits into from
Feb 10, 2023
Merged

refactor: simplify job builders #734

merged 2 commits into from
Feb 10, 2023

Conversation

sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Feb 9, 2023

No description provided.

@coveralls
Copy link

coveralls commented Feb 9, 2023 •
edited

Pull Request Test Coverage Report for Build 4133245542

  • 64 of 66 (96.97%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 91.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/job/spec.go 62 64 96.88%
Totals Coverage Status
Change from base Build 4122075803: -0.04%
Covered Lines: 8371
Relevant Lines: 9100
💛 - Coveralls

@sravankorumilli sravankorumilli merged commit 6d766d7 into main Feb 10, 2023
@sravankorumilli sravankorumilli deleted the simplify-builders branch February 10, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbchaos @coveralls @sravankorumilli