Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix lint errors #736

Merged
merged 12 commits into from
Mar 7, 2023
Merged

refactor: fix lint errors #736

merged 12 commits into from
Mar 7, 2023

Conversation

sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Feb 9, 2023

No description provided.

@coveralls
Copy link

coveralls commented Feb 9, 2023 •
edited

Pull Request Test Coverage Report for Build 4350941443

  • 161 of 168 (95.83%) changed or added relevant lines in 30 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 92.434%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/scheduler/service/job_run_service.go 14 15 93.33%
ext/notify/slack/slack.go 11 12 91.67%
core/scheduler/event.go 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 96.92%
Totals Coverage Status
Change from base Build 4350847615: -0.02%
Covered Lines: 8503
Relevant Lines: 9199
💛 - Coveralls

@sbchaos sbchaos merged commit 9bff876 into main Mar 7, 2023
@sbchaos sbchaos deleted the fix-lint-errors branch March 7, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbchaos @coveralls