Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): buf lint fix #29

Merged
merged 3 commits into from
May 13, 2022
Merged

chore(proto): buf lint fix #29

merged 3 commits into from
May 13, 2022

Conversation

ramey
Copy link
Member

@ramey ramey commented Apr 7, 2022

Change wr.t Proton PR #126

Closing: #29

Signed-off-by: ramey rameygirdhar@gmail.com

@ramey ramey requested a review from NNcrawler April 7, 2022 04:25
@ramey ramey linked an issue Apr 7, 2022 that may be closed by this pull request
Change wr.t Proton PR [#126](raystack/proton#126)

Signed-off-by: ramey <rameygirdhar@gmail.com>
 - Change EventRequest to SendEventRequest
 - Change EventResponse to SendEventResponse
Change wr.t Proton PR [#126](raystack/proton#126)
Signed-off-by: ramey <rameygirdhar@gmail.com>
Copy link
Contributor

@chakravarthyvp chakravarthyvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ensure the test passing
and we can merge then

LGTM otherwise.

@ramey ramey merged commit e376216 into raystack:main May 13, 2022
@ravisuhag
Copy link
Member

@ramey Please remove WIP when PR is ready and we are merging.

@ramey
Copy link
Member Author

ramey commented May 14, 2022

@ramey Please remove WIP when PR is ready and we are merging.

Noted @ravisuhag

@ramey ramey changed the title WIP: chore(proto): buf lint fix chore(proto): buf lint fix May 14, 2022
ramey added a commit to ramey/raccoon that referenced this pull request May 17, 2022
* chore(proto): buf lint fix

Change wr.t Proton PR [#126](raystack/proton#126)

Signed-off-by: ramey <rameygirdhar@gmail.com>

* chore(proto): buf lint fix
 - Change EventRequest to SendEventRequest
 - Change EventResponse to SendEventResponse
Change wr.t Proton PR [#126](raystack/proton#126)

* docs(api) doc update for SendEventRequest and SendEventResponse

Signed-off-by: ramey <rameygirdhar@gmail.com>
@ramey ramey deleted the proto-lint-fix branch May 24, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buf lint changes
3 participants