Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(channel): performance improvements #36

Merged
merged 8 commits into from
Jun 22, 2022

Conversation

ramey
Copy link
Member

@ramey ramey commented May 24, 2022

Changes

The following changes are done as part of this PR -

  • Remove serde interfaces to use direct functions
  • Fix shutdown
  • Change ProduceBulk method to remove CollectRequest

Closing #35

- remove the Event struct from the collector channel
- add only the data fields required by worker as part of collectRequest
@NNcrawler
Copy link
Member

The PR is LGTM. Can you also put the benchmark result as well in the issue?

@ramey
Copy link
Member Author

ramey commented Jun 13, 2022

Performace Benchmarking

Setup

Max Clients - 1000
Batch Size - 100
Batch Interval - 10000
Execution time - 30m

v0.1.1

Server Processing Latency(max_upper)
Screenshot 2022-06-10 at 12 34 11 PM

Min 624ms
Max - 6.71 min
Avg - 45.8s

Batch idle time in channel
Screenshot 2022-06-10 at 12 34 24 PM

Min - 1.03 min
Max - 7.6 min
Avg - 5.6 min

Worker Latency(max_upper)
Screenshot 2022-06-10 at 12 47 38 PM

Min 191 ms
Max 1.02 min
Mean 8.92s

v0.1.3

Server Processing Latency(max_upper)
Screenshot 2022-06-10 at 3 06 09 PM

Min - 6.74s
Max - 17.9 min
Avg 7.79 min

Batch idle time in channel
Screenshot 2022-06-10 at 3 06 04 PM

Min - 2.20 min
Max - 9.09 min
Avg - 6.54 min

Worker Latency(max_upper)
Screenshot 2022-06-10 at 3 05 57 PM

Min - 100ms
Max - 1 min
Avg - 13.2 s

Current Branch

Server Processing Latency(max_upper)
Screenshot 2022-06-12 at 5 28 38 PM

Min - 15ms
Max - 7.04 min
Avg - 1min

Batch idle time in channel
Screenshot 2022-06-12 at 5 28 46 PM

Min - 1.63s
Max - 7.08 min
Avg - 3.69 min

Worker Latency(max_upper)
Screenshot 2022-06-12 at 5 29 04 PM

Min 58ms
Max 3.04s
Avg 512 ms

@ramey ramey changed the title perf(channel): remove Event object from collector channel perf(channel): performance improvements Jun 16, 2022
publisher/kafka.go Show resolved Hide resolved
services/pprof/service.go Show resolved Hide resolved
services/grpc/service.go Outdated Show resolved Hide resolved
services/pprof/service.go Outdated Show resolved Hide resolved
services/pprof/service.go Outdated Show resolved Hide resolved
services/rest/service.go Outdated Show resolved Hide resolved
services/rest/service.go Outdated Show resolved Hide resolved
publisher/kafka_test.go Outdated Show resolved Hide resolved
deserialization/proto.go Show resolved Hide resolved
collection/collector.go Outdated Show resolved Hide resolved
collection/collector.go Outdated Show resolved Hide resolved
collection/collector.go Outdated Show resolved Hide resolved
@chakravarthyvp chakravarthyvp merged commit 2e34f07 into raystack:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance degradation because of additional data in collector
4 participants