Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dockerfile dev file #142

Merged
merged 1 commit into from Aug 4, 2022
Merged

fix: dockerfile dev file #142

merged 1 commit into from Aug 4, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Aug 2, 2022 •
edited

We use Dockerfile.dev to build a tag dev. Our current Dockerfile.dev copied shield to /usr/local/bin/shield but the Dockerfile is copying shield to usr/bin/shield.

We expect the same path between Dockerfile and Dockerfile.dev. We need to update Dockerfile.dev so shield is copied to /usr/bin/shield.

Changes

  • Copy shield to usr/bin
  • Add glibc for compatibility purpose

@mabdh mabdh linked an issue Aug 2, 2022 that may be closed by this pull request
Inconsistent path in Dockerfile.dev #141
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2779291865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.968%
Totals Coverage Status
Change from base Build 2779265837: 0.0%
Covered Lines: 2342
Relevant Lines: 4595
💛 - Coveralls

@mabdh mabdh marked this pull request as ready for review August 2, 2022 04:24
@krtkvrm
Copy link
Member

krtkvrm commented Aug 2, 2022

can you please add description ?

@mabdh
Copy link
Member Author

mabdh commented Aug 2, 2022

@krtkvrm the details is in the issue #141
but anyway let me add it again here

@mabdh
Copy link
Member Author

mabdh commented Aug 4, 2022

@krtkvrm @AkarshSatija can we merge this?

@krtkvrm krtkvrm merged commit 591ea0d into main Aug 4, 2022
@krtkvrm krtkvrm deleted the fix-dockerfile-dev branch August 4, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag ravisuhag approved these changes

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija

@krtkvrm krtkvrm Awaiting requested review from krtkvrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent path in Dockerfile.dev
4 participants
@mabdh @coveralls @krtkvrm @ravisuhag