feat: code instrumentation #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtkvrm
approved these changes
Feb 28, 2023
ishanarya0
force-pushed
the
instrumentation
branch
from
9f62dc0
to
93f62f3
Compare
mabdh
pushed a commit
to goto/shield
that referenced
this pull request
Mar 14, 2023
* test: proxy tests (raystack#196) * test: shield proxy * test: add resource creation after proxy test * chore: cleanup * chore: cleanup * fix: lint issue * feat: add github workflow for proxy test * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: removed pg docker volume * fix: workflow steps * fix: remove failing tests * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * fix: workflow * merge * fix: workflow * test: cleanup * test: cleanup * test: cleanup * fix: types nad logger * test: removed teardown step * fix: add observability middleware * fix: lint * chore: add newline to workflow file * chore: removed numbering from proxy test * refactor: remove APIs that are replaced by relation APIs (raystack#198) * refactor: remove group APIs that are replaced by relation APIs * refactor: remove org APIs that are replaced by relation APIs * refactor: remove group APIs that are replaced by relation APIs * refactor: remove project APIs that are replaced by relation APIs * fix: linting issue * fix: proton commit * fix: ProjectService mock * fix: for user creation, use email from header if missing from body * feat: authz middleware to return 404 when resource not found (raystack#202) * feat: authz middleware to return 404 when resource not found * chore: change log message * test: increase test coverage (raystack#201) * test: fixed TestHandler_CreateRelation * test: added TestHandler_CheckResourcePermission * test: increase coverage of authz hook test * test: add create & delete relation tests * chore: fix lint * refactor: remove unused code in group pkg * fix: lint issue error defination missing * feat: add coverage html output to make test * test: add group TestGetByIDs test * chore: Makefile command flag * fix: lint issue * fix: Makefile * chore: group test cleanup * test: add TestListGroupRelations * test: add TestList for namespace repository * test: add policy test * test: add TestUpdate to postgres policy * test: fix TestList in policy repository test * test: fix policy repository test * test: add TestList to role repository * test: add role repository update test * test: update testcase with metadata to be updated * fix: use salt/mux pkg (raystack#214) * fix: use salt/mux pkg * fix: address port for grpc server * refactor: move registering logic to separate function * chore: update golangci-lint version * chore: add go mod updates * fix: linter issues * fix: disable vet linter * fix: remove SIGKILL & redundant os.Interrupt * fix: code review changes * refactor: use runtime.WithHealthEndpointAt for health endpoints * fix: lint issues * fix: review changes * feat: use project slug in hooks (raystack#208) * fix: use slug and project id interchangibly * fix: ignore org id in hook * fix: tests * fix: tests * fix: also add metadata in project in e2e-test * fix: tests * feat: code instrumentation (raystack#207) * feat: metrics for missing metadata keys * fix: typo * feat: add counter metric for failed resource creation * feat: add counter metric for failed relation creation * feat: add /metrics endpoint to port a separate port * fix: serialization inconsistency while creating a user (raystack#204) * fix: serialization inconsistency while create a user When a user is created/updated it can have additional metadata, this data although is generic blob was getting serialized differently when User is Created vs Updated which was causing behaviours like extra quotes if metadata type is a string. Signed-off-by: Kush Sharma <thekushsharma@gmail.com> * fix: user metadata serialization issue in list, create, update and get endpoints * chore: add new line at the end --------- Signed-off-by: Kush Sharma <thekushsharma@gmail.com> Co-authored-by: Ishan Arya <ishanarya0@gmail.com> * fix: policy api list & get (raystack#212) * fix: proto update * fix: list & get policy to populate actionID, namespaceID and roleID fields * test: fix get all policies test --------- Signed-off-by: Kush Sharma <thekushsharma@gmail.com> Co-authored-by: Ishan Arya <ishanarya0@gmail.com> Co-authored-by: Kush <3647166+kushsharma@users.noreply.github.com>
ravisuhag
pushed a commit
that referenced
this pull request
Mar 23, 2023
* feat: metrics for missing metadata keys * fix: typo * feat: add counter metric for failed resource creation * feat: add counter metric for failed relation creation * feat: add /metrics endpoint to port a separate port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #206