-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oidc authentication and session management #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushsharma
force-pushed
the
authn-session
branch
3 times, most recently
from
April 2, 2023 08:02
e2e4e2f
to
41b5f35
Compare
Pull Request Test Coverage Report for Build 4658548589
💛 - Coveralls |
kushsharma
force-pushed
the
authn-session
branch
from
April 2, 2023 09:43
41b5f35
to
8c64775
Compare
- on successful authentication a cookie with 'sid' is set - on successful authentication a jwt token in response headers is set via 'x-user-token' containing details related to user and its org - jwt public keys are available at /jwks.json Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
kushsharma
force-pushed
the
authn-session
branch
from
April 5, 2023 13:45
8c64775
to
90b0a5c
Compare
pyadav
reviewed
Apr 6, 2023
block_secret_key: "block-secret-should-be-32-chars-" | ||
# once authenticated, server responds with a jwt with user context | ||
token: | ||
# generate key file via "./shield server gen rsa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To generate key file, command is
./shield server keygen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think example dir does not contains all files
Am I missing something?
kushsharma
force-pushed
the
authn-session
branch
from
April 10, 2023 15:01
33b159b
to
90b0a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sid
is setx-user-token
containing details related to the user and its org/jwks.json
examples/auth
directory for usageAdditional config added in
app
section