-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication): add support to persist sessions and flows in database #218
Conversation
Chief-Rishab
commented
Apr 10, 2023
•
edited
edited
- Add support to save user sessions and flows in the postgres database
- Documentation
- Update API and CLI reference
- Update server configurations
Pull Request Test Coverage Report for Build 4691795498
💛 - Coveralls |
@Chief-Rishab can you rebase this with main, I'll review it after |
@kushsharma this PR is ready for review now |
@@ -0,0 +1,8 @@ | |||
CREATE TABLE IF NOT EXISTS flows( | |||
id uuid PRIMARY KEY DEFAULT uuid_generate_v4(), | |||
method varchar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of varchar
can we use text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't VARCHAR
and TEXT
same if we don't specify the number to limit the characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they are same, I thought in rest of the migrations we are using text
so I thought we may want to keep it consistent, I just checked looks like we actually use varchar
. Should be fine then.
…tabase (#218) * feat(authentication): persists sessions and flows in db * doc: update cli and api references * docs: update server configurations * chore: add changes from suggestion * chore: fix lint error * chore: add flow model for postgres * chore: add changes from suggestions